search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
312 stars 51 forks source link

-Wdeprecated-copy-dtor warnings #163

Closed nlohmann closed 3 years ago

nlohmann commented 3 years ago

Using release version 10.4.0 and Clang 11 (C++17 build) on Linux, I get the following -Wdeprecated-copy-dtor warnings:

In file included from ../external/approvaltests.cpp/ApprovalTests/namers/../Approvals.h:13:
../external/approvaltests.cpp/ApprovalTests/namers/DefaultNamerDisposer.h:17:9: error: definition of implicit copy constructor for 'DefaultNamerDisposer' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-dtor]
../external/approvaltests.cpp/ApprovalTests/namers/SeparateApprovedAndReceivedDirectoriesNamer.cpp:32:16: note: in implicit copy constructor for 'ApprovalTests::DefaultNamerDisposer' first required here
In file included from ../external/approvaltests.cpp/ApprovalTests/reporters/CIBuildOnlyReporterUtils.cpp:1:
In file included from ../external/approvaltests.cpp/ApprovalTests/../ApprovalTests/reporters/CIBuildOnlyReporterUtils.h:4:
../external/approvaltests.cpp/ApprovalTests/../ApprovalTests/reporters/FrontLoadedReporterDisposer.h:17:9: error: definition of implicit copy constructor for 'FrontLoadedReporterDisposer' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-dtor]
../external/approvaltests.cpp/ApprovalTests/reporters/CIBuildOnlyReporterUtils.cpp:10:16: note: in implicit copy constructor for 'ApprovalTests::FrontLoadedReporterDisposer' first required here

Let me know if you need further details.

claremacrae commented 3 years ago

Thank you for reporting this. We will pick this up when we can, but unfortunately have quite a lot in flight at the moment.

PRs gratefully received, in the meantime.

nlohmann commented 3 years ago

Done.