search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
317 stars 51 forks source link

use current version of mdsnippets #169

Closed SimonCropp closed 3 years ago

claremacrae commented 3 years ago

Hi Simon, it's helpful with PRs to know the motivation for the change.

In this particular case, there's a good reason why I pin the version of mdsnippets, and that's because when the mdsnippets output changes, it has a tendency to sometimes break our tests of the publishing of documentation... (and therefore to actually to break the publishing of the documentation itself)

So sorry, I can't accept this.

claremacrae commented 3 years ago

I just added some more info in a long comment, for future reference, as to why we use a pinned version: https://github.com/approvals/ApprovalTests.cpp/commit/412a61460e3710c6721201718e5c177a423d97d0

Just as a quick experiment, I tried updating to the new version - 23.0.0 - and got this error message:

Failed: `Exclude` is obsolete. Use `ExcludeDirectories`.

Which is another reason to control when we do the updates... to decide when we want to pickup breaking changes...

This also reminded me that sometimes updating to the newest mdsnippets requires updating dotnet version - which can also trip up flow... So is another reason to stick with a known version, until we need to update, or have time to update.