Releases 10.6.0 and 10.7.0 contain invalid #include line

[claremacrae]

The problem code is this:

// ******************** From: FrameworkIntegrations.h

#include <ApprovalTests.hpp>

namespace ApprovalTests
{
    class FrameworkIntegrations
    {
    public:
        static void
        setTestPassedNotification(FileApprover::TestPassedNotification notification);

        static void setCurrentTest(ApprovalTests::TestName* currentTest);
    };
}

I saw it via this build error, when using the single-header file:

error: 'ApprovalTests.hpp' file not found with <angled> include; use "quotes" instead
#include <ApprovalTests.hpp>
         ^~~~~~~~~~~~~~~~~~~
         "ApprovalTests.hpp"
1 error generated.

It's wrong at several levels:

• We shouldn't include any of our own header files via <...>, as they will be presumed to be system headers, and not processed correctly by our release script.
  • The angle-brackets get inserted by CLion, during its refactoring... Others have already reported this: https://youtrack.jetbrains.com/issue/CPP-5501
  • This has tripped me up multiple times
• We also shouldn't include the simulated single header file - ApprovalTests.hpp - in any of the library headers, as it will end up #including itself in the final released header

[claremacrae]

This was fixed in the 10.7.1 release.