search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
312 stars 51 forks source link

If received and approved filenames are identical, tests spuriously pass #178

Closed claremacrae closed 3 years ago

claremacrae commented 3 years ago

I was playing around with custom namers, and accidentally generated a namer that generated identical received and approved file names.

I then wrote a test that I expected to fail, as the approved content didn't match the source code.

However it passed!

And I eventually worked out that it was because it was effectively testing if received content matched received content, which always passes!

claremacrae commented 3 years ago

This will be fixed in the next release