search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
318 stars 51 forks source link

Rename and restructure the lib directory #19

Closed claremacrae closed 5 years ago

claremacrae commented 5 years ago

It would be clearer if it were called third_party/

I'd also like to create sub-directories in - one for each included framework, e.g.

This would allow us to make e.g. our doctest tests only pick up doctest headers, and would more quickly show up mistakes as we move most of our existing tests from catch2 to doctest.

It's fairly unlikely that any users are using a clone of this project directly, but just out of kindness, I would include this in the next release that allows for breaking changes, i.e. 5.0.0

claremacrae commented 5 years ago

This will also extend nicely when catch3 is released.

claremacrae commented 5 years ago

This image shows what the cmake target dependencies look like now - there is a separate target for each 3rd-party dependency.

dependencies

I created it using the commands given here - except saving in .png format instead of .svg: https://github.com/claremacrae/project_dependencies_viz#alternative-approaches---if-you-use-cmake

The image in that post shows what the dependencies were in this project before today's changes, and before the addition of the addition of ApprovalTests_DocTest_Tests