Fix CMake warnings - Githubissues

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows

https://approvaltestscpp.readthedocs.io/en/latest/

Apache License 2.0

318 stars 51 forks source link

Fix CMake warnings #29

Closed alastairUK closed 5 years ago

alastairUK commented 5 years ago

I am far from a CMake expert but I think these changes should resolve warnings/error when using Visual Studio in MSVC and Clang-cl mode.

There is an outstanding issue when compiling with X64-Debug on MSVC

Command line warning D9025: overriding '/ZI' with '/Zi'

I think this is coming from googletest but haven't tracked it down yet.

claremacrae commented 5 years ago

This looks fine to me - I don't have any experience yet with clang-cl - I've just created #30 to consider adding it to our CI builds.

I see that all the CI builds on this passed, except the now-traditional travis timing out on one...

So I'll go ahead and merge this.

Sorry for the duplication of cmake text in 3 places... I've been aware that I should create a cmake sub-directory, and create an include file there - it just hasn't made it anywhere near the top of my todo list yet....