search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
318 stars 51 forks source link

F!! Remove Catch1 support and add `catch2` prefix to all `#includes` for `catch.hpp` #64

Closed dheater closed 4 years ago

dheater commented 4 years ago

Closes #62

WARNING: This PR removes support for the Catch 1 unit test framework. See #62 for discussion.

Per the current maintainer for Catch2

"I strongly recommend going with #include "catch2/catch.hpp"

Adding catch2 to the path allows ApprovalTests.cpp to work well with the way Catch2 exports target include directories using CMake.

The drawback is that there is no simple/clean way to maintain support for Catch 1 without breaking compatibility. Catch 1 is maintained to support C++98. Both ApprovalTests.cpp and Catch2 depend on features of C++11

The following post describes the changes from Catch 1 to Catch 2: https://levelofindirection.com/blog/catch2-released.html Theses release notes outline the breaking changes from Catch 1 to Catch 2: https://github.com/catchorg/Catch2/releases/tag/v2.0.1