search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
318 stars 51 forks source link

Boost ut Change in Template Parameters #66

Closed jwillikers closed 4 years ago

jwillikers commented 4 years ago

Boost ut removed the template parameter TLocation in a recent commit. This template parameter will need to be removed from functions in UTApprovals.h to maintain compatibility with the next Boost ut release.

jwillikers commented 4 years ago

Removing the template parameter TLocation from UTApprovals.h does indeed solve the issue and Approval Tests once again builds using the most recent commit of Boost ut at this time.

claremacrae commented 4 years ago

@krzysztof-jusiak Please note this. Can the removed TLocation parameter be reinstated to fix the ApprovalTests.cpp integration, for example?

krzysztof-jusiak commented 4 years ago

I will prepare a MR for ApprovalTests with a fix, TLocation template parameter is not needed anymore, source_location is used instead.

claremacrae commented 4 years ago

This was fixed in #67 - thanks Krys.

jwillikers commented 4 years ago

Thanks @claremacrae and @krzysztof-jusiak!