static_assert wrongly triggered in Starter Project on Cygwin AppVeyor builds

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows

https://approvaltestscpp.readthedocs.io/en/latest/

Apache License 2.0

318 stars 51 forks source link

static_assert wrongly triggered in Starter Project on Cygwin AppVeyor builds #92

Closed claremacrae closed 4 years ago

claremacrae commented 4 years ago

For details, see https://github.com/approvals/ApprovalTests.cpp.StarterProject/issues/10

I wasn't able to figure out why this build failure happened in the StarterProject and not this one, but it was definitely a real problem in that we were depending on _WIN32 being set by Cygwin CMake builds, and that was not always the case.

I've relaxed that static_assert check on __FILE__, because some Cygwin builds use unix-style filenames, and some used Windows-style filenames.

claremacrae commented 4 years ago

This was fixed in afa222de90975bf70d62216ef83650cb76c66964