search

approvals / go-approval-tests

Apache License 2.0
90 stars 22 forks source link

Old go #54

Closed aleclerc-cio closed 1 week ago

aleclerc-cio commented 1 week ago

This should be small

Small pull requests are great and easy for me to understand and accept Please try prefix every commits in the pull request with Arlo's git notation Prefix Meaning
e development enviroment only - not production
d documentation only
t tests only
R!! Refactoring
B!! Bug Fix
F!! New Feature

But it's not small!

Then you should setup a remote pairing session with Llewellyn ( llewellyn.falco@gmail.com ) Usually the sessions are between 45-90 minutes.

assuming you still feel it is small, please include

Description

A description of what the PR achieves.

The solution

Outline the implementation. Any tests that are affected.

Notation

I prefer lots of very small commits prefixed with Arlo's git notation

Summary by Sourcery

Update the Go version in the CI workflow and add a script for running tests with cache cleaning, race detection, and coverage reporting.

Build:

CI:

sourcery-ai[bot] commented 1 week ago

Reviewer's Guide by Sourcery

This PR makes two main changes: it pins the Go version to 1.22.3 in the GitHub Actions workflow (instead of using 'stable'), and adds a new test script that ensures tests run without Go's build cache and includes race detection and coverage reporting.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Pin Go version in GitHub Actions workflow
  • Replace 'stable' Go version with specific version 1.22.3
 .github/workflows/test.yml
Add new test execution script with enhanced testing configuration
  • Disable Go build cache for both build and test commands
  • Add race condition detection to test execution
  • Configure test coverage reporting with atomic mode
  • Create executable shell script for consistent test execution
 run_tests.sh
Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).