approvals / go-approval-tests

Apache License 2.0
90 stars 22 forks source link

Before fail #55

Closed aleclerc-cio closed 1 week ago

aleclerc-cio commented 1 week ago

This should be small

Small pull requests are great and easy for me to understand and accept Please try prefix every commits in the pull request with Arlo's git notation Prefix Meaning
e development enviroment only - not production
d documentation only
t tests only
R!! Refactoring
B!! Bug Fix
F!! New Feature

But it's not small!

Then you should setup a remote pairing session with Llewellyn ( llewellyn.falco@gmail.com ) Usually the sessions are between 45-90 minutes.

assuming you still feel it is small, please include

Description

A description of what the PR achieves.

The solution

Outline the implementation. Any tests that are affected.

Notation

I prefer lots of very small commits prefixed with Arlo's git notation

Summary by Sourcery

Enhance the CI workflow by adding a matrix strategy to test across multiple operating systems and update the actions to their latest versions.

CI:

sourcery-ai[bot] commented 1 week ago

Reviewer's Guide by Sourcery

This PR updates the GitHub Actions workflow configuration to support multi-platform testing and upgrades action versions. The changes include running tests on Windows, Ubuntu, and macOS, implementing a matrix strategy, and updating the versions of checkout and setup-go actions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implemented multi-platform testing strategy in GitHub Actions workflow
  • Added matrix strategy configuration with Windows, Ubuntu, and macOS
  • Disabled fail-fast behavior to allow all platform tests to complete regardless of failures
  • Updated runner configuration to use matrix OS value
.github/workflows/test.yml
Updated GitHub Actions dependencies to latest versions
  • Upgraded checkout action from v2 to v4
  • Upgraded setup-go action from v2.2.0 to v5.1.0
  • Added explicit Go version specification (1.21.13)
.github/workflows/test.yml

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).