approvers / OreOreBot2

限界開発鯖を代表する BOT はらちょ を TypeScript+discord.js で作り直し。 オレオレ BOT です。別に詐欺とかはしません。
https://haracho.approvers.dev
MIT License
13 stars 2 forks source link

refactor: CommandResponder を runner へ移動 #1093

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Type of Change:

リファクタ

Details of implementation (実施内容)

runner モジュールのコードは他のモジュールのコードに依存性はいけないはずですが, CommandRunner はその定義が service モジュールのコードに依存していました. そのため, いくつかの interface を runner 側へ移するリファクタリングを行いました.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62ce41e
Status: ✅  Deploy successful!
Preview URL: https://71b06a92.oreorebot2.pages.dev
Branch Preview URL: https://refactor-command-runner.oreorebot2.pages.dev

View logs

codecov[bot] commented 1 year ago

Codecov Report

Merging #1093 (62ce41e) into main (6849c9c) will decrease coverage by 0.29%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   72.72%   72.43%   -0.29%     
==========================================
  Files          80       80              
  Lines        5521     5464      -57     
  Branches      486      486              
==========================================
- Hits         4015     3958      -57     
  Misses       1021     1021              
  Partials      485      485              
Flag Coverage Δ
unittests 72.43% <75.00%> (-0.29%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/bot/src/service/command/channel-info.ts 89.77% <66.66%> (-0.34%) :arrow_down:
packages/bot/src/service/command/debug.ts 87.50% <66.66%> (-0.56%) :arrow_down:
packages/bot/src/service/command/dice.ts 82.60% <66.66%> (-0.45%) :arrow_down:
packages/bot/src/service/command/guild-info.ts 96.46% <66.66%> (-0.06%) :arrow_down:
packages/bot/src/service/command/gyokuon.ts 82.29% <66.66%> (-0.54%) :arrow_down:
packages/bot/src/service/command/judging.ts 79.08% <66.66%> (-0.41%) :arrow_down:
packages/bot/src/service/command/kaere.ts 71.38% <66.66%> (-0.24%) :arrow_down:
packages/bot/src/service/command/kokusei-chousa.ts 94.64% <66.66%> (-0.28%) :arrow_down:
packages/bot/src/service/command/meme.ts 75.16% <66.66%> (-0.50%) :arrow_down:
packages/bot/src/service/command/party.ts 82.78% <66.66%> (-0.21%) :arrow_down:
... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more