approvers / OreOreBot2

限界開発鯖を代表する BOT はらちょ を TypeScript+discord.js で作り直し。 オレオレ BOT です。別に詐欺とかはしません。
https://haracho.approvers.dev
MIT License
13 stars 2 forks source link

feat: 引数なしでVC参加するタイプのコマンドにstartサブコマンドを追加 #1111

Closed MikuroXina closed 11 months ago

MikuroXina commented 12 months ago

Resolves #1040.

Type of Change:

機能の新規追加, テストの追加

Details of implementation (実施内容)

引数なしでボイスチャンネルに参加する方式だったコマンド群に対して, start サブコマンドでも参加するように機能を追加しました. またその場合でもこれまでと同じ動作になることを確かめるテストを追加しました.

codecov[bot] commented 12 months ago

Codecov Report

Merging #1111 (4a92f72) into main (bb03b54) will increase coverage by 0.13%. The diff coverage is 60.46%.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   72.43%   72.57%   +0.13%     
==========================================
  Files          80       80              
  Lines        5464     5484      +20     
  Branches      486      487       +1     
==========================================
+ Hits         3958     3980      +22     
+ Misses       1021     1018       -3     
- Partials      485      486       +1     
Flag Coverage Δ
unittests 72.57% <60.46%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/bot/src/service/command/party.ts 83.13% <87.50%> (+0.34%) :arrow_up:
packages/bot/src/service/command/kaere.ts 73.06% <54.28%> (+1.67%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cloudflare-workers-and-pages[bot] commented 11 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a92f72
Status:⚡️  Build in progress...

View logs