approvers / OreOreBot2

限界開発鯖を代表する BOT はらちょ を TypeScript+discord.js で作り直し。 オレオレ BOT です。別に詐欺とかはしません。
https://haracho.approvers.dev
MIT License
13 stars 2 forks source link

fix(ci): fix problem with incorrect tagValue passed by release-please #1221

Closed m1sk9 closed 9 months ago

m1sk9 commented 9 months ago

close #1148

Details of implementation (実施内容)

release-please が受け渡すタグ値が不正な問題について steps.release.outputs.releases_created から値を受け渡してもらえるようにしてみました. 直るかどうかはもう知りません.

v4 では steps.release.outputs.releases_created で不具合が起きているようです. 一度上の変更は取り消して if式 を修正してみました. 直るかどうかはもう知りません.

See also: https://github.com/google-github-actions/release-please-action/issues/912

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b9ea2d4) 72.57% compared to head (8a9146b) 72.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1221 +/- ## ======================================= Coverage 72.57% 72.57% ======================================= Files 80 80 Lines 5484 5484 Branches 487 487 ======================================= Hits 3980 3980 Misses 1018 1018 Partials 486 486 ``` | [Flag](https://app.codecov.io/gh/approvers/OreOreBot2/pull/1221/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/approvers/OreOreBot2/pull/1221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers) | `72.57% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 9 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a9146b
Status: ✅  Deploy successful!
Preview URL: https://05823b5c.oreorebot2.pages.dev
Branch Preview URL: https://ci-release-please.oreorebot2.pages.dev

View logs