approvers / OreOreBot2

限界開発鯖を代表する BOT はらちょ を TypeScript+discord.js で作り直し。 オレオレ BOT です。別に詐欺とかはしません。
https://haracho.approvers.dev
MIT License
13 stars 2 forks source link

feat: Improve condition of updating commands #1345

Closed MikuroXina closed 4 months ago

MikuroXina commented 4 months ago

Closes #1343.

Type of Change:

機能の改善

Dealing with Problems (問題への対処)

登録済コマンドが更新されているかどうかの判定関数を, 少し丁寧に実装することで条件を厳しくした.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.04%. Comparing base (9848f85) to head (58ad94c).

Files Patch % Lines
packages/bot/src/service/command/register.ts 84.21% 0 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1345 +/- ## ========================================== + Coverage 58.96% 59.04% +0.07% ========================================== Files 112 112 Lines 7323 7337 +14 Branches 530 530 ========================================== + Hits 4318 4332 +14 Misses 2476 2476 Partials 529 529 ``` | [Flag](https://app.codecov.io/gh/approvers/OreOreBot2/pull/1345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/approvers/OreOreBot2/pull/1345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers) | `59.04% <84.21%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=approvers#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.