apps4av / avare

Avare Aviation GPS for Android
Other
154 stars 122 forks source link

fullscreen mode #267

Open pballer2oo7 opened 7 years ago

pballer2oo7 commented 7 years ago

I'd like to be able to turn off the Navigation Bar and the Status Bar to take advantage of full screen height, particularly while using approach plates.

The api 19 way of doing it is pretty sweet. Both of the bars autohide but can be pulled up with a swipe near the screen edge.

We can put a check if the system is running api 19 and the user enables the feature. We can set this mode on the view associated with the MainActivity. Nothing changes if the user is running 18 or older or does not enable the feature. Is this an acceptable approach?

If this is done, some other small UI tweaks should be made as well:

pballer2oo7 commented 7 years ago

need to fix WXB, Plan, and List.

When you open one of these tabs fullscreen and then enable the soft keyboard, the keyboard covers up and prevents you from being able to scroll to the bottom of the screen and complete the form.

it's expected behavior due to the webview. see https://code.google.com/p/android/issues/detail?id=5497

couple of options:

JohnW4SBA commented 7 years ago

bars autohide but can be pulled up with a swipe near the screen edge.

Seems like a cool optional feature that's Off by default (I'm a big fan of starting newbies in "simple" mode). Are there any handles or buttons in the corners when auto-hid, or could some be added? Seems like a good safety feature to have something as a reminder at the left edge corner where the bars would normally be.

pballer2oo7 commented 7 years ago

I agree completely with you about default behavior, JohnW4SBA. I have it defaulted to off in my branch.

I haven't added any bars or handles. immersive mode does teach the user how to use it (how to recall the bars) the first time it's enabled. we can also add it to the tips and help.

apps4av commented 7 years ago

Have you tested thoroughly? We do not have a test team so developers make sure their changes are thoroughly tested. Once a PR is merged, and released, and serious issues are found, it will be backed out with longer code merge cycle from that developer for future PRs. Thanks for your help.

On Mon, Jan 16, 2017 at 7:19 PM, pballer2oo7 notifications@github.com wrote:

need to fix WXB, Plan, and List.

When you open one of these tabs, and then enable the soft keyboard, the stable immersion prevents you from being able to scroll to the bottom of the screen and filling out the entire form.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apps4av/avare/issues/267#issuecomment-272990757, or mute the thread https://github.com/notifications/unsubscribe-auth/ACz4z-xQBsh_iyqDRAJF4o4i01QWXO3Aks5rTAkGgaJpZM4LlFxM .

-- Regards, Apps For Aviators Support,

We encourage users to use the Forum for all questions. Any updates to the forum will help other users, who might have similar questions. Forum: https://groups.google.com/forum/#!forum/apps4av-forum

pballer2oo7 commented 7 years ago

@apps4av, agreed. I won't open the PR until it's ready.