search

apps4av / avare

Avare Aviation GPS for Android
Other
148 stars 120 forks source link

Cleanup location view #468

Closed apps4av closed 1 year ago

apps4av commented 1 year ago

Moving the pop up for destination to Near and Find. More uniform behavior. Cleanup with get/set. Moved BT IO to #2 so BT issues wont crash the app on fresh install. Caught and fixed busy loop in USBIn IO.

apps4av commented 1 year ago

Check long press on Find elements (airports, GPS, navaids, addresses) and Near elements (airports).

On Sat, Sep 3, 2022, 12:39 PM Ron Walker @.***> wrote:

@.**** approved this pull request.

Appears mostly to be cleanup of style and object scope access. Did a pull and tested affected areas. Did not test out the USB "bug" changes, no hardware.

— Reply to this email directly, view it on GitHub https://github.com/apps4av/avare/pull/468#pullrequestreview-1095540295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWPRTZ6YOYPWJREKXOXOMDV4N5MZANCNFSM6AAAAAAQD5OZ2U . You are receiving this because you authored the thread.Message ID: @.***>

N520TX commented 1 year ago

Yes - tested that panel. The buttons that display are context sensitive based upon the type of the list select that was long pressed. When this gets merged, this is where I'll hook the "Set DME" functionality in to as well, stack it on top of the "WX" button.

apps4av commented 1 year ago

Actually all those context sensitive buttons are gone. Everything and all buttons are in pop out dialog now with this PR.

On Sat, Sep 3, 2022, 1:33 PM Ron Walker @.***> wrote:

Yes - tested that panel. The buttons that display are context sensitive based upon the type of the list select that was long pressed. When this gets merged, this is where I'll hook the "Set DME" functionality in to as well, stack it on top of the "WX" button.

— Reply to this email directly, view it on GitHub https://github.com/apps4av/avare/pull/468#issuecomment-1236169281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWPRT4ZZ2DHKW32ZHXIKR3V4ODYDANCNFSM6AAAAAAQD5OZ2U . You are receiving this because you authored the thread.Message ID: @.***>

N520TX commented 1 year ago

I see that now - was in the wrong branch. That pop out dialog on the "find" panel behaves the way the long press did on the chart. Same dialog. Any way to "gray out" or otherwise disable the PLATE and CSUP selections when they are not applicable to the station selected ? Is the red "X" button required given the system "Back" provides same functionality ?

apps4av commented 1 year ago

Noted. If you need more real estate to add buttons, you can use the second row. I will look into disabling other buttons