apps4av / avare

Avare Aviation GPS for Android
Other
148 stars 120 forks source link

Ground traffic filter config (defaulted to hide), and audible min speed filter #479

Closed shanelenagh closed 1 year ago

shanelenagh commented 1 year ago

Per Avare Github issue #371, I added the airborne ADSB flag up to the traffic object, and also saved the same flag for ownship into the traffic cache. I then used these newly propogated flags to add configuration options for both visual and audible traffic display/alerts (both defaulted to hide the ground traffic). In addition, per the suggestion in #371 I also added for the audible alerts the option of a mininum speed under which audible alerts are not played (defaulted to "0", which essentially means the feature/config is disabled by default), to allow for the option of effectively disabling the audible alerts completely during low-speed, high workload times like takeoff and landing--when the craft would be airborne, but still perhaps not desiring the pollution of the audible alerts when there are competing priorities and more relevant audible avionics feedback (e.g., GPWS or radio communication with the tower). I also did a fair amount of audible alerts codebase cleanup and decomposition since my initial audible PR--sorry if that presents a little clutter vs. being able to read only the new filter items.

saabnut commented 1 year ago

This is nice work. Is it possible to ignore traffic where the closing speed between ownship and targets is low in the horizontal plane, like 20 KTS? Is latency taken into account as to target suggested position? Thank you for your contribution.

On Sun, Oct 9, 2022 at 8:54 PM shanelenagh @.***> wrote:

Closed #479 https://github.com/apps4av/avare/pull/479.

— Reply to this email directly, view it on GitHub https://github.com/apps4av/avare/pull/479#event-7550203281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAT66FYVFRCQXTDW2AXZH3WCNSMXANCNFSM6AAAAAARA34BXQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>