search

apps4av / avare

Avare Aviation GPS for Android
Other
148 stars 120 forks source link

Increase audible closing alert (TCPA) accuracy (+ previous ground & speed traffic filters PR) #482

Closed shanelenagh closed 1 year ago

shanelenagh commented 1 year ago

This PR contains the previous PR for adding the traffic ground and speed filters, but if possible I wanted to include this change as well--accounting for the time that it takes to speak/play the first part of a TCPA audible alert (e.g., "traffic alpha, closing in...") in the calculations of how many seconds are remaining until closest point of approach (CPA). This calculation is done as close as possible to the playing of the message, to provide the most accurate estimate possible for the CPA. In prior testing I found that the alert seemed off by a part of a second up to a bit over a second, and this time was reduced by accounting for the time needed to speak this "prefix" to the actual seconds value.

saabnut commented 1 year ago

There is an advisory circular that speaks to latency in the ADSB-in system. AC 20-172B. The built-in latency is not insignificant.

On Wed, Oct 12, 2022 at 11:50 AM shanelenagh @.***> wrote:

This PR contains the previous PR for adding the traffic ground and speed filters, but if possible I wanted to include this change as well--accounting for the time that it takes to speak/play the first part of a TCPA audible alert (e.g., "traffic alpha, closing in...") in the calculations of how many seconds are remaining until closest point of approach (CPA). This calculation is done as close as possible to the beginning of the playing of the message, to provide the most accurate estimate possible for the CPA. In prior testing I found that the alert seemed off by a part of a second up to a bit over a second, and this time was reduced by accounting for the time needed to speak this "prefix" to the actual seconds value.

You can view, comment on, or merge this pull request online at:

https://github.com/apps4av/avare/pull/482 Commit Summary

File Changes

(11 files https://github.com/apps4av/avare/pull/482/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/apps4av/avare/pull/482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAT66CK4NK7FUF27XBABTLWC3M4BANCNFSM6AAAAAARDNTIRU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

shanelenagh commented 1 year ago

I found a bug with one of the recent changes in both of these latest PR's, so I am closing both until I can fully test my fixes.