search

appscot / sails-orientdb

OrientDB adapter for Waterline / Sails.js ORM
MIT License
25 stars 23 forks source link

Support OrientDB 2.1 #52

Open dmarcelino opened 9 years ago

dmarcelino commented 9 years ago
wolf4ood commented 8 years ago

hi @dmarcelino

there are news about 2.1.x support? I've tried to run 

npm test

on master branch against 2.1.9

i've got a bunch of error like

 OrientDB.RequestError: expression item ']' cannot be resolved because current record is NULL

Even with ODB 2.0.12 i got those errors.

I guess that is the waterline version. In the latest passed build https://travis-ci.org/appscot/sails-orientdb/jobs/84569655 the used version is 0.10.26 while my local version is 0.10.30

I would like to help you on that. Thanks Enrico

dmarcelino commented 8 years ago

Hi @maggiolo00, I've started a new job (that doesn't involve coding) and I haven't had much time to look into this. Feel free to PR a fix and I'll review it. Thanks

gianpaolom commented 7 years ago

HI @dmarcelino, I was trying to start a project using sails-orientdb, following advice about waterline and waterline schema in the Readme, and on top of OrientDB 2.2.x. But I found an issue with DELETE route, with SQL query breaking and trowing an error. So I tried downgrading to 2.1, then 2.0 and here it works.

After searching in ODB doc I found this: http://orientdb.com/docs/last/Release-2.1.0.html#strict-sql-parser

Disabling strict parser it started working in 2.1 and 2.2.

I don't know if the issue is related to sails-orientdb or more to waterline-sequel-orientdb. It seemed worth to point this out, even if I don't know if it can be of any help

dmarcelino commented 7 years ago

Hi @gianpaolom, thanks for the input. Would you mind submitting a PR with the change? Thanks