Closed thraxil closed 5 years ago
OK. Switched it to latest
. The only problem with that is that we will have conflicts once we are also dealing Ironwood, etc.
@thraxil either lastest
or hawthorn.master
works fine, but let's worry now about Hawthorn. Fixing that minor issue for Ironwood is a tax that I'd be happy to pay when that day comes -- the day when we want to migrate form Hawthorn to Ironwood.
This should push the
edxapp
docker image toappsembler/edxapp:hawthorn
after a successful merge toappsembler/hawthorn/master
.The docker hub credentials are in TravisCI's settings for the repo. I tested this out by doing the build/push step in the main
script
section and it seems to work fine.The only real thing to be aware of with this is that it takes a good 25 minutes to build and push the image. So people will need to understand that they can't
docker pull
immediately after a PR is merged and expect to get the new image. But this should still be better than requiring one of us to do it manually every time.Some questions for discussion:
hawthorn
tag the only one we care about? should we also make sure we push tolatest
? (devstack useshawthorn
, right?)