appsembler / configuration

a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go
GNU Affero General Public License v3.0
15 stars 13 forks source link

Build edxapp image and push to docker hub from Travis #196

Closed thraxil closed 5 years ago

thraxil commented 5 years ago

This should push the edxapp docker image to appsembler/edxapp:hawthorn after a successful merge to appsembler/hawthorn/master.

The docker hub credentials are in TravisCI's settings for the repo. I tested this out by doing the build/push step in the main script section and it seems to work fine.

The only real thing to be aware of with this is that it takes a good 25 minutes to build and push the image. So people will need to understand that they can't docker pull immediately after a PR is merged and expect to get the new image. But this should still be better than requiring one of us to do it manually every time.

Some questions for discussion:

thraxil commented 5 years ago

OK. Switched it to latest. The only problem with that is that we will have conflicts once we are also dealing Ironwood, etc.

OmarIthawi commented 5 years ago

@thraxil either lastest or hawthorn.master works fine, but let's worry now about Hawthorn. Fixing that minor issue for Ironwood is a tax that I'd be happy to pay when that day comes -- the day when we want to migrate form Hawthorn to Ironwood.