Hardcode favicon not found (404) for custom domains

appsembler / configuration

a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go

GNU Affero General Public License v3.0

15 stars 13 forks source link

Hardcode favicon not found (404) for custom domains #261

Closed OmarIthawi closed 5 years ago

OmarIthawi commented 5 years ago

The custom domains nginx configs aren't reading the nginx_lms_extra_locations value, so I'm hardcoding the value instead.

Disclaimer: I don't fully understand the subject, so that's literally my 8th pull request to attempt to fix it.

Long story on both Slack and Trello.

johnbaldwin commented 5 years ago

I'll second @thraxil 's comment. Let's go with this if it addresses the 404 issue for custom domains. Do we want to track this as an outstanding tech debt issue so that we can dig into it more at a future date?

OmarIthawi commented 5 years ago

It's working on production! The new servers were much needed obviously!

cc: @johnbaldwin @ahmedaljazzar @melvinsoft @thraxil!

Closing this PR because it's not needed!