search

appsembler / configuration

a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go
GNU Affero General Public License v3.0
15 stars 13 forks source link

downgrade urllib3 #338

Closed thraxil closed 3 years ago

thraxil commented 3 years ago

The backups script for GCP installs a bunch of python libraries system-wide. One of those as a side-effect now results in a version of urllib3 getting installed system-wide that then breaks ansible on subsequent deploys:

https://appsembler.atlassian.net/wiki/spaces/ED/pages/390004931/Failed+to+install+repo+key

A proper fix would be to move the whole backups script setup into a virtualenv so we don't get conflicts. But since this is only a problem on Hawthorn (Juniper uses a newer version of Ansible that is OK with upgrading urllib3), the simple workaround for now is to just downgrade urllib3 back to a known safe version at the end of the task.

thraxil commented 3 years ago

@OmarIthawi I don't see any reason that we'd merge appsembler/hawthorn/master into appsembler/juniper/master.

OmarIthawi commented 3 years ago

It's likely that we'll need to sync changes from hawthorn to juniper similar to what we do in the edx-platform repo: https://github.com/appsembler/edx-platform/pull/795

Cherry-picking is also a viable solution, but it's easy to forget those changes. We've piled few changes so far: