search

appsembler / configuration

a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go
GNU Affero General Public License v3.0
15 stars 13 forks source link

Juniper upgrade - allow custom white label command to create sites #356

Closed johnbaldwin closed 3 years ago

johnbaldwin commented 3 years ago

Reason for this commit is the PR:

https://github.com/appsembler/edx-platform/pull/875

A custom edx-platform command now exists to create sites and configurations and add these to a new TrustedApplication model which replaces the old TrustedClient model that was in Hawthorn.

The reason for the custom command is to reduce customization of edx-platform core code

The default behavior is to use the existing create_sites_and_configurations Django management command that we can override in --extra-vars (edx-configs)

If we do not call the whitelabel role when running a deploy, then there's no point to this PR and we have to go back and trace through how we mark OAuth applications as trusted so as to not wipe our app tokens (like ecommerce, discovery, AMC) when there's a password reset

johnbaldwin commented 3 years ago

Thanks @thraxil . Given what you typed above, I'm just going to close this PR w/out merging. cc @OmarIthawi