appsembler / configuration

a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go
GNU Affero General Public License v3.0
15 stars 13 forks source link

Ensure migration task runs by checking for COMMON_MYSQL_MIGRATE_PASS truthiness correctly RED-3045 #406

Closed shadinaif closed 2 years ago

shadinaif commented 2 years ago

Fix for https://appsembler.atlassian.net/browse/RED-3045

Turned out that COMMON_MYSQL_MIGRATE_PASS|bool is resolved to false even if COMMON_MYSQL_MIGRATE_PASS|length is greater than zero!!

bool filter is a conversion of True string into a boolean, not a boolean check as we would intuitively assume. See here


Make sure that the following steps are done before merging:

shadinaif commented 2 years ago

Sure @OmarIthawi , changed 👍🏼