Catch and retry video module YT IFrame API ready errs

bryanlandia commented 1 year ago

Change description

Retry setting window.onYouTubeIframeAPIReady.resolve to JQuery Deferred obj .resolve up to 3 times before finally failing Log err message to console Catch and retry only TypeErrors which should result from .resolve TypeError

This is direclty in edx-platform since I couldn't figure out how to override in the theme due to the webpack bundling that is done directly into VideoBlockPreview.js via add_webpack_to_fragment in video_module.py

Type of change

[x] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Checklists

Development

[x] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[x] Pull request linked to task tracker where applicable

github-actions[bot] commented 1 year ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with	`open-release/nutmeg.master`
Benchmark conflicts with `main`	299
Current conflicts	299
Summary	Good work! No added conflicts.

Comparing with	`master`
Benchmark conflicts with `main`	316
Current conflicts	316
Summary	Good work! No added conflicts.

New conflicting files with 'master'

``` common/lib/xmodule/xmodule/js/src/video/01_initialize.js ```

github-actions[bot] commented 1 year ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with	`open-release/nutmeg.master`
Benchmark conflicts with `main`	299
Current conflicts	299
Summary	Good work! No added conflicts.

Comparing with	`master`
Benchmark conflicts with `main`	316
Current conflicts	316
Summary	Good work! No added conflicts.

New conflicting files with 'master'

``` common/lib/xmodule/xmodule/js/src/video/01_initialize.js ```

github-actions[bot] commented 1 year ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with	`open-release/nutmeg.master`
Benchmark conflicts with `main`	299
Current conflicts	299
Summary	Good work! No added conflicts.

Comparing with	`master`
Benchmark conflicts with `main`	316
Current conflicts	316
Summary	Good work! No added conflicts.

New conflicting files with 'master'

``` common/lib/xmodule/xmodule/js/src/video/01_initialize.js ```

github-actions[bot] commented 1 year ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with	`open-release/nutmeg.master`
Benchmark conflicts with `main`	299
Current conflicts	299
Summary	Good work! No added conflicts.

Comparing with	`master`
Benchmark conflicts with `main`	316
Current conflicts	316
Summary	Good work! No added conflicts.

New conflicting files with 'master'

``` common/lib/xmodule/xmodule/js/src/video/01_initialize.js ```

appsembler / edx-platform