ENG-97 Try/Catch around more of the onYouTubeIframeAPIReady code to retry

[bryanlandia]

Change description

Still getting onYouTubeIframeAPIReady TypeErrors once in a while when loading YouTube videos in courseware.

When I reproduced it, I didn't see any of the JS console messages that I put in, like

console.error('Error while trying to resolve the Deferred object responsible for calling OnYouTubeIframeAPIReady callbacks.');
console.error('window.onYouTubeIframeAPIReady is ' + window.onYouTubeIframeAPIReady);

so the try/catch I put in to retry the function wasn’t getting executed at least in this case.

This PR:

• catches a TypeError in more of the function code
• allows up to 5 retries (was 3)
• waits 500ms before a retry

Type of change

• [x] Bug fix (fixes an issue)
• [ ] New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

• [x] Lint rules pass locally
• [ ] Application changes have been tested thoroughly
• [ ] Automated tests covering modified code pass

Security

• [x] Security impact of change has been considered
• [x] Code follows company security practices and guidelines

Code review

• [x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
• [ ] "Ready for review" label attached and reviewers assigned
• [ ] Changes have been reviewed by at least one other contributor
• [ ] Pull request linked to task tracker where applicable

[github-actions[bot]]

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with	open-release/nutmeg.master
Benchmark conflicts with main	299
Current conflicts	299
Summary	Good work! No added conflicts.

Comparing with	master
Benchmark conflicts with main	317
Current conflicts	317
Summary	Good work! No added conflicts.