appsembler / edx-platform

Appsembler Tahoe fork of Open edX. Branches: `main` for Juniper and `hawthorn/main` for Hawthorn.
https://appsembler.com/products/tahoe/
GNU Affero General Public License v3.0
13 stars 15 forks source link

ENG-97 Refactor try/catch for window.onYouTubeIframeAPIReady.resolve on video initialization #1371

Closed bryanlandia closed 1 year ago

bryanlandia commented 1 year ago

Change description

Refactor try/catch for window.onYouTubeIframeAPIReady.resolve on video initialization Rename Error instance as seems to have caused a name collision when minified

Type of change

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

Security

Code review

github-actions[bot] commented 1 year ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 318
Current conflicts 318
Summary Good work! No added conflicts.
bryanlandia commented 1 year ago

Finished testing on devstack, looks good.