appsembler / edx-platform

Appsembler Tahoe fork of Open edX. Branches: `main` for Juniper and `hawthorn/main` for Hawthorn.
https://appsembler.com/products/tahoe/
GNU Affero General Public License v3.0
13 stars 15 forks source link

Fix: Handle Request objects in Segment fetch override #1382

Closed amirtds closed 10 months ago

amirtds commented 10 months ago

Change description

This change fixes the TypeError that was thrown when trying to call substr on a Request object and ensures that analytics events are correctly replicated to the appropriate Segment backends.

Type of change

Related issues

https://appsembler.atlassian.net/browse/ENG-334

Checklists

Development

Security

Code review

github-actions[bot] commented 10 months ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 320
Current conflicts 320
Summary Good work! No added conflicts.
github-actions[bot] commented 10 months ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 320
Current conflicts 320
Summary Good work! No added conflicts.
github-actions[bot] commented 10 months ago

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 320
Current conflicts 320
Summary Good work! No added conflicts.