search

appsembler / edx-platform

Appsembler Tahoe fork of Open edX. Branches: `main` for Juniper and `hawthorn/main` for Hawthorn.
https://appsembler.com/products/tahoe/
GNU Affero General Public License v3.0
13 stars 15 forks source link

Refactor ENABLE_COURSE_DISCOVERY hack on devstack #197

Closed OmarIthawi closed 6 years ago

OmarIthawi commented 6 years ago

191 introduced a change to make the ENABLE_COURSE_DISCOVERY configurable from the lms.env.json file on devstack. However the solution used another feature.

The suggestion is to refactor it:

FEATURES['ENABLE_COURSE_DISCOVERY'] = ENV_TOKENS['FEATURES'].get('ENABLE_COURSE_DISCOVERY', FEATURES['ENABLE_COURSE_DISCOVERY'])
OmarIthawi commented 6 years ago

@bryanlandia what do you think?

OmarIthawi commented 6 years ago

Fixed in https://github.com/appsembler/edx-platform/pull/198