search

appsembler / edx-theme-codebase

The shared part of Appsembler's edX theme among all customers and installations
Other
2 stars 0 forks source link

Discovery course card organization doesn't obey Advanced Setting display override #2

Closed bryanlandia closed 5 years ago

bryanlandia commented 7 years ago

We are seeing for Trinity Eucalyptus this discrepancy: https://trello.com/c/7dtKHh2v/177-correct-organization-display-on-search-page-eucalyptus

Looks like course cards on dashboard obey 'Course Organization Display String', but cards from course discovery (/courses page) do not.

See: https://github.com/appsembler/edx-theme-codebase/blob/eucalyptus/master/lms/templates/discovery/course_card.underscore#L11

(only org, not content.display_organization)

bryanlandia commented 7 years ago

cc @tkeemon

bryanlandia commented 7 years ago

Trinity: minor changes for Eucalyptus staging server

bryanlandia commented 7 years ago

@bezidejni @grozdanowski - Branch https://github.com/appsembler/edx-theme-codebase/tree/bryan/fix-discovery-course-org-display-override fixes the issue, but is only tested with Eucalyptus. edx-platform appsembler/eucalyptus/master has the corresponding changes needed to work with this. See commit https://github.com/appsembler/edx-platform/commit/3dd1110f17d79cf7abe8299282fca4f1f8a7a5b6