cookie notification improvements - Githubissues

appsembler / edx-theme-customers

Customer theme configuration and overrides

3 stars 2 forks source link

cookie notification improvements #249

Closed grozdanowski closed 2 years ago

grozdanowski commented 2 years ago

Change description

Add the options to set the Learn More link in cookie notification target and label. Also fix styling of that link.

Paired with: https://github.com/appsembler/edx-theme-codebase/pull/217 https://github.com/appsembler/appsembler-dashboard/pull/95

Type of change

[x] Bug fix (fixes an issue)
[x] New feature (adds functionality)

Related issues

Fix [#1]()

Checklists

Development

[x] Lint rules pass locally
[x] Application changes have been tested thoroughly
[x] Automated tests covering modified code pass

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[x] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable