Increase timeout before gtm init to 3 seconds for yt video api compat - Githubissues

appsembler / edx-theme-customers

Customer theme configuration and overrides

3 stars 2 forks source link

Increase timeout before gtm init to 3 seconds for yt video api compat #280

Closed bryanlandia closed 1 year ago

bryanlandia commented 1 year ago

Change description

Cockroach still saw on and off problems with YouTube video loading because of an issue with GTM initialization even after introducing a 1 second timeout. Trying to increase timeout to 3 secs.

Type of change

[x] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[x] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[x] Pull request linked to task tracker where applicable