Closed johnbaldwin closed 3 years ago
Merging #224 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 38 38
Lines 1950 1950
=======================================
Hits 1781 1781
Misses 169 169
Impacted Files | Coverage Δ | |
---|---|---|
figures/models.py | 96.98% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d96dd9b...a10587b. Read the comment docs.
@OmarIthawi Thanks for the comments. One item I forgot was running and adding the migration file. I'll inspect the SQL shell to see what indexes are already on the learner course grade metrics table and if the SO collective is right, which from reading the posts, looks that way in this case, then I'll remove those parameters
No longer need this PR. Superseded by https://github.com/appsembler/figures/pull/288
Query performance was very slow for this model. Added indexing to the fields which we use for filtering