Closed johnbaldwin closed 4 years ago
melvinsoft
commented
4 years ago @johnbaldwin Maybe I'm looking wrong, but I'm not seeing this fix here: https://github.com/appsembler/figures/pull/219
I know isn't related to performance, but it would be great to bundle it in case is not.
codecov-commenter
commented
4 years ago Merging #225 into master will decrease coverage by
0.11%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 91.31% 91.19% -0.12%
==========================================
Files 37 38 +1
Lines 1876 2169 +293
==========================================
+ Hits 1713 1978 +265
- Misses 163 191 +28 | Impacted Files | Coverage Δ | |
|---|---|---|
| figures/serializers.py | 94.37% <100.00%> (-1.16%) |
:arrow_down: |
| figures/migrations/0010_site_monthly_metrics.py | 93.33% <0.00%> (-6.67%) |
:arrow_down: |
| figures/metrics.py | 87.58% <0.00%> (-0.40%) |
:arrow_down: |
| figures/pipeline/enrollment_metrics.py | 98.33% <0.00%> (ø) |
|
| figures/views.py | 92.95% <0.00%> (+1.21%) |
:arrow_up: |
| figures/pipeline/course_daily_metrics.py | 96.04% <0.00%> (+1.21%) |
:arrow_up: |
| figures/sites.py | 67.46% <0.00%> (+2.46%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0293795...63acdbe. Read the comment docs.
johnbaldwin
commented
4 years ago @melvinsoft I only picked the critical fix needed for Tahoe prod. The other commits are specific to ginkgo or testing
melvinsoft
commented
4 years ago @johnbaldwin Ok, thanks! Got it.
thraxil
commented
4 years ago What is the status on this? It's still a Draft PR but hasn't changed in 10 days and AFAICT, 3.10 is already released.
johnbaldwin
commented
4 years ago @thraxil Yeah, I can get rid of this one. Thanks for the nudge
DRAFT PR to run tests on build branch with hot fix cherry pick of
bbefd3e30a0aca97cda8fce73c56d6d12c42f2b2