appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

progress indicator for populate_daily_metrics #228

Closed thraxil closed 4 years ago

thraxil commented 4 years ago

This is a simple quality of life improvement.

The daily pipeline takes a long time to run, and currently gives no indication of how far along in the process it is.

Adding a log message like this means that I can quickly tail the logs and form a ballpark estimate of how much longer it will be running. Eg, if we want to deploy (which we need to stop the pipeline for currently), seeing that it's at 1995 of 2000, I'd be inclined to just wait a few minutes for it to finish rather than stop the pipeline, deploy, and restart it.

Similarly, if it's been running for 12 hours and we see that it's only made it 10% of the way through, that would indicate that there's a bug or some issue slowing it down and we need to stop the pipeline and investigate before the next day's pipeline starts running and things get even worse.

codecov-commenter commented 4 years ago

Codecov Report

Merging #228 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   91.28%   91.29%           
=======================================
  Files          38       38           
  Lines        1951     1953    +2     
=======================================
+ Hits         1781     1783    +2     
  Misses        170      170           
Impacted Files Coverage Δ
figures/tasks.py 84.37% <100.00%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0f6061...0a2acc4. Read the comment docs.