search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Fixes CourseDailyMetricsSerializer when average_progress is 1.00 #230

Closed johnbaldwin closed 4 years ago

johnbaldwin commented 4 years ago

Updated CourseDailyMetricsSerializer.average_progress max_digits to allow 3 digits. Was previously 2 digits which failed the serializer validation when the average_progress value was 1.00.

Also updated the average_progress field definition to set min and max values. Unfortunately, this validation is not being tested. Did some initial timeboxed investigation, but stopped at time limit of 1 hour. Note here that we need to investigation and make sure validation works.

Updated the serializer tests

codecov-commenter commented 4 years ago

Codecov Report

Merging #230 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          38       38           
  Lines        1953     1953           
=======================================
  Hits         1783     1783           
  Misses        170      170
Impacted Files Coverage Δ
figures/serializers.py 94.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bc1acd...b3c8af9. Read the comment docs.