appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

John/update monthly task #242

Closed johnbaldwin closed 4 years ago

johnbaldwin commented 4 years ago

Likely cause is that I had the default settings to False to run the monthly metrics job (yeah, that's on me). This should be on by default since the monthly job is part of Figures standard workflow

Also added a log timing instrumentation context manager and fixed package dependency versions.

Found an incompatibility with Ginkgo in figures.mau. There is a query that is not compatible with Django 1.8

So for now, disabled failing Ginkgo tests. Then assess the fix and need

codecov-commenter commented 4 years ago

Codecov Report

Merging #242 into master will increase coverage by 0.11%. The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   91.50%   91.62%   +0.11%     
==========================================
  Files          40       41       +1     
  Lines        2061     2078      +17     
==========================================
+ Hits         1886     1904      +18     
+ Misses        175      174       -1     
Impacted Files Coverage Δ
figures/helpers.py 100.00% <ø> (ø)
figures/views.py 92.39% <94.11%> (ø)
figures/log.py 100.00% <100.00%> (ø)
figures/models.py 95.36% <100.00%> (ø)
figures/pipeline/enrollment_metrics.py 98.36% <100.00%> (ø)
figures/settings/lms_production.py 100.00% <100.00%> (+5.26%) :arrow_up:
figures/tasks.py 85.14% <100.00%> (+0.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33e61a3...4a27cb9. Read the comment docs.

melvinsoft commented 4 years ago

@johnbaldwin I did a light review, all changes makes sense to me. Since Omar is on vacation, I'd say let's merge it and test on Staging and let's ping Omar when is back from vacation for a more detailed review, and we can address changes in a follow up PR. Thanks!