search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Fix certificates count as proxy for course completions #244

Closed johnbaldwin closed 4 years ago

johnbaldwin commented 4 years ago

Reworked function to get the latest sum of cerfificates across courses for the site. This is done by querying CourseDailyMetrics.

This is a workaround. It fixes the metric, but is really just a patch. What needs to happen is to rethink this metric, what we want to say and how to efficiently (storage and query performance) manage certificates achived over time.

Especially since we only want to capture data as they change

codecov-commenter commented 4 years ago

Codecov Report

Merging #244 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          41       41           
  Lines        2129     2131    +2     
=======================================
+ Hits         1954     1956    +2     
  Misses        175      175
Impacted Files Coverage Δ
figures/models.py 95.36% <ø> (ø)
figures/pipeline/course_daily_metrics.py 94.06% <ø> (ø)
figures/metrics.py 87.86% <100.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a882e9b...32f5eb5. Read the comment docs.