Closed BbrSofiane closed 3 years ago
Admin note: Before we merge this into Figures master
, we should create a last 0.3.x release (0.3.17) IFF there are any other commits after this one: https://github.com/appsembler/figures/commit/27c20fbd6fe9cfba0b021ea51130ce8148cb84c4
If we don't have any more commits, then we don't need to because we can create a '0.3.x' branch from tag 0.3.16
@BbrSofiane FYI, I have a new PR, https://github.com/appsembler/figures/pull/266
This PR is to fix a Ginkgo backward compatibility issue. I adapted your char_filter
method to fix it, so I will do a PR against your juniper_upgrade
branch once PR 266 has been approved and merged into Appsembler's Figures master branch
@johnbaldwin sounds good, I'm waiting the PR.
@OmarIthawi Thanks for the review! I've gone through an committed the suggestions that you made.
@johnbaldwin Should I look into the conflicts?
Implemented changes to make figures compatible with open edX Juniper.
The changes mostly revolve around Python 3 and Django 2 compatibility with some minor changes in open edX mocks behaviours. #241