search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Changes to make figures compatible with open edX Juniper #264

Closed BbrSofiane closed 3 years ago

BbrSofiane commented 4 years ago

Implemented changes to make figures compatible with open edX Juniper.

The changes mostly revolve around Python 3 and Django 2 compatibility with some minor changes in open edX mocks behaviours. #241

johnbaldwin commented 4 years ago

Admin note: Before we merge this into Figures master, we should create a last 0.3.x release (0.3.17) IFF there are any other commits after this one: https://github.com/appsembler/figures/commit/27c20fbd6fe9cfba0b021ea51130ce8148cb84c4

If we don't have any more commits, then we don't need to because we can create a '0.3.x' branch from tag 0.3.16

johnbaldwin commented 4 years ago

@BbrSofiane FYI, I have a new PR, https://github.com/appsembler/figures/pull/266

This PR is to fix a Ginkgo backward compatibility issue. I adapted your char_filter method to fix it, so I will do a PR against your juniper_upgrade branch once PR 266 has been approved and merged into Appsembler's Figures master branch

BbrSofiane commented 4 years ago

@johnbaldwin sounds good, I'm waiting the PR.

BbrSofiane commented 4 years ago

@OmarIthawi Thanks for the review! I've gone through an committed the suggestions that you made.

BbrSofiane commented 4 years ago

@johnbaldwin Should I look into the conflicts?