Closed johnbaldwin closed 4 years ago
Merging #272 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 41 41
Lines 2161 2161
=======================================
Hits 1982 1982
Misses 179 179
Impacted Files | Coverage Δ | |
---|---|---|
figures/filters.py | 88.61% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f3133d...6b0f6c9. Read the comment docs.
packagine.versions is a very convenient way to compare package versions for compatibility support. However, we cannot expect that the Open edX deployment will have
packaging
installed.This commit undos the dependency on
packaging
which was introduced through backportingdjango_filters
version checking to handle breaking changes between the versions. Instead we added a crude version parsing function intofigures.filters
and currently only use it fordjango_filters
which has the major, minor, and point versions in the usual 'x.y.z' dot delimited numeric format. So this will work for Django Filter but no guarantee for all packages.