search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Create PULL_REQUEST_TEMPLATE #327

Closed iamjazzar closed 3 years ago

iamjazzar commented 3 years ago

Encouraging contributors to write documentation and tests for their PRs whenever needed. I found it really helpful in Wharf repo, and we are applying it in all major repos.

johnbaldwin commented 3 years ago

@ahmedaljazzar Thanks for the idea. Just letting you know I see your PR here. I'll leave this one open until I create an issue to shape the broader context. We have internal contributors, an external contributor and if things go in the direction we think, there will be more external contributors. Therefore, we have to make the message very clear (doesn't have to be long, short is good), but we have to make the message clear

OmarIthawi commented 3 years ago

Closed in favor of #366. Thanks @ahmedaljazzar!