search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Hawthorn GeneratedCertificate Mock is wrong #332

Closed johnbaldwin closed 3 years ago

johnbaldwin commented 3 years ago

As you discovered, @estherjsuh , the GeneratedCertificate mock is wrong, missing the In Hawthorn, theon_delete=models.CASCADE` in the mock code:

This is the production model:

https://github.com/appsembler/edx-platform/blob/appsembler/tahoe/master/lms/djangoapps/certificates/models.py#L233

So we need to fix this for the Hawthorn mock

The Juniper mock looks correct: https://github.com/appsembler/figures/blob/master/mocks/juniper/lms/djangoapps/certificates/models.py#L11

estherjsuh commented 3 years ago

Hi @johnbaldwin, I linked a PR for this issue. Please review. Thanks!