Handle old, slash-separated course ids and course-vX:... style

appsembler / figures

Reporting and data retrieval app for Open edX

MIT License

44 stars 37 forks source link

Handle old, slash-separated course ids and course-vX:... style #351

Closed bryanlandia closed 3 years ago

bryanlandia commented 3 years ago

Allows Figures to run on sites with courses created in e.g., 2015

Split route path into two options: if there are no forward-slashes we assume course id is like course-v1:xxx I didn't figure out how to get a nice named match param into my regex for that one but if you see how to, feel free. Second one looks specifically for a course id style with two slash separations.

bryanlandia commented 3 years ago

Thanks @johnbaldwin I have just been testing directly against DHIS2 staging :D And yes, it's working for old and new style course ids.

bryanlandia commented 3 years ago

Thanks guys. I'll rebase and merge