search

appsembler / figures

Reporting and data retrieval app for Open edX
MIT License
44 stars 37 forks source link

Revert Ginkgo devsite courseware PR #433

Closed johnbaldwin closed 2 years ago

johnbaldwin commented 2 years ago

In regard to the PRs

Background

https://github.com/appsembler/figures/pull/423 which was an update for the outdated PR, https://github.com/appsembler/figures/pull/330, which in turn was created because of the Ironwood Figures issue reported here https://discuss.openedx.org/t/runtimeerror-while-installing-figures-on-ironwood/4000

Figures does not support Ironwood, at least in figures.compat.

Why this was reported as a Ginkgo error, I can't speak to. I searched the page text and "Ginkgo" doesn't even occur

Inspection

In Ginkgo, the app namespace actually IS courseware and not lms.djangoapps.courseware

See from the Django shell session on a production Ginkgo server:

>>> from django.conf import settings
>>> [rec for rec in settings.INSTALLED_APPS if 'courseware' in rec]
['courseware']

On Hawthorn

I checked a Hawthorn deployment to make sure that is accurate in the settings. Hawthorn updated the certificates namespace, but not yet the courseware namespace:

>>> from django.conf import settings
>>> [rec for rec in settings.INSTALLED_APPS if 'certificate' in rec]
['lms.djangoapps.certificates.apps.CertificatesConfig']
>>> [rec for rec in settings.INSTALLED_APPS if 'courseware' in rec]
['courseware']
>>> from openedx.core.release import RELEASE_LINE
>>> RELEASE_LINE
'hawthorn'