Make create_tahoe_site atomic - Githubissues

appsembler / tahoe-sites

Tahoe multi-tenancy app for site separation models and helpers for the edx-platform.

MIT License

0 stars 0 forks source link

Make create_tahoe_site atomic #59

Open shadinaif opened 1 year ago

shadinaif commented 1 year ago

Change description

Make create_tahoe_site atomic. It's three steps data insert, it should be atomic

Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Related issues

Checklists

Development

[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

OmarIthawi commented 1 year ago

@shadinaif i recommend using the atomic in outter most possible place e.g. Django command or scripts one off command.

In very rare cases we can add it inside individual functions, but I don't think this one is one of them.