fix: qa feedbacks for query string and get_settings exception handling - Githubissues

appsembler / xblock-grade-fetcher

Grade Fetcher XBlock

MIT License

2 stars 1 forks source link

fix: qa feedbacks for query string and get_settings exception handling #37

Closed amirtds closed 2 years ago

amirtds commented 2 years ago

Change description

Put proxies get_settings under exception handling
Returning some error message to users when exception happens and prevent the infinite button load
Using Urlib to parse query params

Type of change

[x] Bug fix (fixes an issue)

Checklists

Development

[x] Lint rules pass locally
[x] Application changes have been tested thoroughly

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[x] "Ready for review" label attached and reviewers assigned