update PrismXBlock fields and views - Githubissues

appsembler / xblock-prismjs

An XBlock for adding code highlighting via the PrismJS library.

MIT License

0 stars 1 forks source link

update PrismXBlock fields and views #5

Closed estherjsuh closed 3 years ago

estherjsuh commented 3 years ago

Change description

add height field to PrismXBlock class
refactor views to use render_django_template instead of format

Type of change

[ ] Bug fix (fixes an issue)
[x] New feature (adds functionality)

Related issues

Fix [#1]()

Checklists

Development

[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

estherjsuh commented 3 years ago

@OmarIthawi @melvinsoft thank you both!! 😃