search

appsembler / xblock-video

Universal Video XBlock with pluggable backend for many video hosting providers
GNU General Public License v3.0
18 stars 50 forks source link

BrightCove has deprecated playback speed setup method used #26

Open bryanlandia opened 6 years ago

bryanlandia commented 6 years ago

Putting the data attribute on the <video> tag is deprecated by BrightCove

data-setup="{"playbackRates": [0.5, 1.0, 1.5, 2.0] }”

Should be replaced with something like 

videojs.registerPlugin('VSP', function () { var player = this; addPlaybackButton = function () { var playbackRateMenuButton = new videojs.getComponent('PlaybackRateMenuButton'); var oldPlaybackRateMenuButton = player.controlBar.playbackRateMenuButton; var playbackRates = new playbackRateMenuButton(player, { playbackRates: [0.5, 1, 1.5, 2] }); player.controlBar.addChild(playbackRates); player.controlBar.el().insertBefore(playbackRates.el, oldPlaybackRateMenuButton.el); player.controlBar.removeChild(oldPlaybackRateMenuButton); }; player.on("ready", function() { addPlaybackButton(); }); });
bryanlandia commented 6 years ago

This may actually not be a valid Issue.