appsforartists / midicast

a web extension that streams songs from a web page to a MIDI instrument
Apache License 2.0
16 stars 3 forks source link

Use declarativeContent + SetIcon to highlight the icon when a MIDI is found #36

Open appsforartists opened 7 years ago

appsforartists commented 7 years ago

midicast should be a browser_action rather than a page_action, to ensure the controls can be opened even when there are no MIDIs on the current page. Still, it would be a nice user experience for the icon to change when there are MIDIs available.

chrome.declarativeContent.SetIcon ought to be able to handle this, but it doesn't work with browser actions right now. Poke Devlin about this, and see when it's fixed. Then, use it.